feat: Pass props to I18nProvider.defaultComponent in Trans.render style #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ilyadoroshin
changed the title
|
@andrii-bodnar could you, please, check? and merge if it's ok?) |
|
Hi @ilyadoroshin! Unfortunately, I have no permission to review and merge PRs. Probably, someone else should look into this |
|
@semoal hi, perhaps you could check'n'merge? |
|
@semoal please? |
|
LGTM; thanks for the contribution! We will try to release a new version along the week |
divyansh7924
pushed a commit
to divyansh7924/js-lingui
that referenced
this pull request
Oct 5, 2022
…le (lingui#1242) Co-authored-by: Ilya Doroshin <idoroshin@aligntech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for that PR is to have more control inside defaultComponent.
I'm using your awesome library with nextjs and loading translations asyncronically on a client side, but for the first render I'd like to be able to display some kind of skeleton.
The possibilities with this change are huge: we can even make some kind of i18n-WYSIWYG.