Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support multiple locales in extract command #1858

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

dan-dr
Copy link
Contributor

@dan-dr dan-dr commented Feb 22, 2024

Description

Adds multiple locales support for --locale option, similar to the experimental extract implementation.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 7:42am

Copy link

github-actions bot commented Feb 22, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@dan-dr dan-dr changed the title support multiple locales in extract command feat(cli): support multiple locales in extract command Feb 24, 2024
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-dr thank you!

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 76.48%. Comparing base (3d7c9ae) to head (0ec8289).
Report is 3 commits behind head on main.

Files Patch % Lines
packages/cli/src/lingui-extract.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   76.66%   76.48%   -0.19%     
==========================================
  Files          81       81              
  Lines        2083     2088       +5     
  Branches      532      533       +1     
==========================================
  Hits         1597     1597              
- Misses        375      380       +5     
  Partials      111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan-dr
Copy link
Contributor Author

dan-dr commented Mar 3, 2024

What needs to happen to merge? :)

@vonovak
Copy link
Collaborator

vonovak commented Mar 3, 2024

Hi! Strictly speaking, you first want to do the trimming and then the filtering 🙈🙂

@dan-dr
Copy link
Contributor Author

dan-dr commented Mar 4, 2024

Hi! Strictly speaking, you first want to do the trimming and then the filtering 🙈🙂

yikes! 😨

@dan-dr
Copy link
Contributor Author

dan-dr commented Mar 4, 2024

done

@andrii-bodnar andrii-bodnar changed the base branch from main to next March 6, 2024 10:41
@andrii-bodnar andrii-bodnar merged commit a2987ae into lingui:next Mar 6, 2024
17 of 18 checks passed
@dan-dr
Copy link
Contributor Author

dan-dr commented Apr 24, 2024

not released yet? 😭

@andrii-bodnar
Copy link
Contributor

andrii-bodnar commented Apr 26, 2024

@dan-dr It has been merged into the next branch and will be released in Lingui v4.

Edit: I think Andrii meant v5 🙂

@dan-dr
Copy link
Contributor Author

dan-dr commented Apr 28, 2024

got it. why though? could be useful right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants