Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macro): fix failure when macro meets function carrying #1884

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Mar 11, 2024

Description

fixes: #1797 (comment)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 9:41am

Copy link

github-actions bot commented Mar 11, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (a2987ae) to head (bedc35c).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1884      +/-   ##
==========================================
+ Coverage   77.05%   77.07%   +0.02%     
==========================================
  Files          83       83              
  Lines        2131     2133       +2     
  Branches      550      550              
==========================================
+ Hits         1642     1644       +2     
  Misses        379      379              
  Partials      110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunsii
Copy link
Contributor

yunsii commented Mar 11, 2024

Looks nice, so I need a new next version to test 😂

Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
@thekip
Copy link
Collaborator Author

thekip commented Mar 11, 2024

@yunsii you can patch it locally, directly in node_modules or use this instruction to run development version in your local project

@andrii-bodnar andrii-bodnar merged commit 1a45d6a into lingui:next Mar 11, 2024
16 checks passed
@thekip thekip deleted the fix/carrying-fail branch March 11, 2024 10:09
@yunsii
Copy link
Contributor

yunsii commented Mar 11, 2024

@thekip Yes, I can use pnpm patch temporarily 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants