Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): process falsy values with JSX semantics #1906

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Apr 4, 2024

Description

Fixes #1904

Despite this is not marked as breaking change, but i expect this may start to behave differently for some users, that's why base of this PR is "next"

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 2:52pm

Copy link

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.06%. Comparing base (13f9ccb) to head (71027a9).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1906      +/-   ##
==========================================
- Coverage   77.18%   77.06%   -0.13%     
==========================================
  Files          84       84              
  Lines        2165     2158       -7     
  Branches      559      556       -3     
==========================================
- Hits         1671     1663       -8     
- Misses        381      382       +1     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar
Copy link
Contributor

@thekip Is there a reason why this PR is targeting the next branch? If possible, it would be better to ship it in the v4 release

@thekip
Copy link
Collaborator Author

thekip commented Apr 5, 2024

@thekip Is there a reason why this PR is targeting the next branch? If possible, it would be better to ship it in the v4 release

Despite this is not marked as breaking change, but i expect this may start to behave differently for some users, that's why base of this PR is "next"

@andrii-bodnar andrii-bodnar merged commit 6bb8983 into lingui:next Apr 5, 2024
17 checks passed
@andrii-bodnar andrii-bodnar linked an issue Apr 5, 2024 that may be closed by this pull request
3 tasks
@thekip thekip deleted the fix/falsy-values-as-jsx branch April 8, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Trans> breaks React JSX semantics with regards to booleans
2 participants