Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): fix macro export conditions for NodeNext and Bundler res… #1915

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Apr 11, 2024

…olutions

Description

it turned out when only "require" condition is present Typescript will complain about this package when NodeNext or Bundler module resolution is enabled

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 8:33am

Copy link

github-actions bot commented Apr 11, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.86 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@thekip
Copy link
Collaborator Author

thekip commented Apr 12, 2024

Here e2e test catch some issue with @lingui/macro i'm figuring out is it a false positive or a real issue which could potentially happend for a users.

@thekip
Copy link
Collaborator Author

thekip commented Jun 17, 2024

This one is done

@andrii-bodnar andrii-bodnar merged commit 46ac32f into lingui:next Jun 17, 2024
14 checks passed
@thekip thekip deleted the fix/macro-export-conditions branch June 17, 2024 13:47
JSteunou pushed a commit to JSteunou/js-lingui that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants