Elevate redirection to a warning tagged http-redirected #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2023
Include the HTTP status code and reason in the message.
The section header names are used when parsing linkcheckerrc. This reverts commit f0b6ddd.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2023
Elevate redirection to a warning tagged http-redirected 2185f6e
fghaas
added a commit
to fghaas/cleura-docs
that referenced
this pull request
Sep 20, 2023
Since linkchecker 10.3.0, external links that are being redirected (that is, they result in HTTP 301 or 302, rather than 200) result in a warning. Since we are running linkchecker in strict mode (that is, not ignoring warnings), this means the link check now fails on such links. This is not good, however it would also not be good to just ignore all warnings, as we would if we ran with --no-warnings. We just don't want to fail on redirects. Unfortunately, the `ignorewarnings` option in the linkchecker configuration file, which allows us to ignore only *specific* warnings (like `http-redirected`, in this case) has no equivalent CLI option. Thus, we must bring back the .linkcheckerrc file (which we dropped in 49eeb6e), and set that option in the config file. References: https://linkchecker.github.io/linkchecker/man/linkchecker.html#return-value https://linkchecker.github.io/linkchecker/man/linkcheckerrc.html#filtering linkchecker/linkchecker#750
fghaas
added a commit
to fghaas/cleura-docs
that referenced
this pull request
Sep 20, 2023
Since linkchecker 10.3.0, external links that are being redirected (that is, they result in HTTP 301 or 302, rather than 200) result in a warning. Since we are running linkchecker in strict mode (that is, not ignoring warnings), this means the link check now fails on such links. This is not good, however it would also not be good to just ignore all warnings, as we would if we ran with --no-warnings. We just don't want to fail on redirects. Unfortunately, the `ignorewarnings` option in the linkchecker configuration file, which allows us to ignore only *specific* warnings (like `http-redirected`, in this case) has no equivalent CLI option. Thus, we must bring back the .linkcheckerrc file (which we dropped in 49eeb6e), and set that option in the config file. References: https://linkchecker.github.io/linkchecker/man/linkchecker.html#return-value https://linkchecker.github.io/linkchecker/man/linkcheckerrc.html#filtering linkchecker/linkchecker#750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the HTTP status code and reason in the message.
Log ignored warning messages as information.
Closes: #64
Closes: #617