Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenerateNodeMap(...): improve framing performance with large sets of objects #32

Merged
merged 1 commit into from
Jul 11, 2018
Merged

GenerateNodeMap(...): improve framing performance with large sets of objects #32

merged 1 commit into from
Jul 11, 2018

Conversation

dtivel
Copy link
Collaborator

@dtivel dtivel commented Jul 4, 2018 •
edited
Loading

Resolve #31.

Using the repro in the issue before and after this change, I see a ~97% improvement.

Trial Before (seconds) After (seconds)
1 505.8915237 13.2601851
2 508.9117335 11.458
3 545.5377558 12.084075
4 582.9262411 10.1112375
5 512.2979849 13.1105859
6 505.554008 11.7665342
7 501.6279932 10.7252669
8 504.7128402 10.1413444
9 505.5059026 10.7213306
10 500.5442 13.1355745
Average 517.3510183 11.65141341

All tests pass.

@goofballLogic
Copy link
Member

Confirmed that all tests pass

@goofballLogic goofballLogic merged commit 66f585b into linked-data-dotnet:master Jul 11, 2018
@dtivel dtivel mentioned this pull request Jul 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtivel @goofballLogic