Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency xmldom #540

Merged
merged 2 commits into from
Dec 26, 2021
Merged

Update dependency xmldom #540

merged 2 commits into from
Dec 26, 2021

Commits on Dec 25, 2021

  1. Update dependency xmldom 

    Switching from package `xmldom` to `@xmldom/xmldom`, which resolves the security issue present in latest xmldom version 0.6.0:
GHSA-5fg8-2547-mr8q

The reason is that the maintainers were forced to switch to a scoped package since 0.7.0:
 xmldom/xmldom#271

- I used node 12 to run `npm install`.
- I executed `npm run test` on my machine without failure
- `npm run build:types` failed since `@xmldom/xmldom` ships with types. I will push a separate commit to fix that.
- all other steps of `npm run prepublishOnly` work fine

I'm one of the xmldom maintainers. Don't hesitate to ask me questions.
    @karfau
    karfau committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    2038a66 View commit details
    Browse the repository at this point in the history

  2. test(ts): Infer type by using a type checker for Element 

    `namepsaceUri` is only present on the `Element` type.
By using a type checker ts knows that we have the right type.
    @karfau
    karfau committed Dec 25, 2021
    Configuration menu
    Copy the full SHA
    0909dbf View commit details
    Browse the repository at this point in the history