-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nan API may have changed in Node 12 #41
Comments
After looking into it a bit, this seems to be a problem with Nan, as they still have to update to Node 12. |
I took a fast look into the error messages and there is more to do then update NAN. NAN provides already an API for this in 2.13.2, e.g. use |
#42 can indeed be closed. Can somebody PR this? I'm afraid I don't know NAN or c++ well enough to give it a go. |
Decided to take a swing at it in #43 , effort was ok in the end. |
Recently, I started having Travis failures when using this lib on Node 12.
Starting from this line: https://travis-ci.org/comunica/comunica-actor-rdf-resolve-quad-pattern-hdt/jobs/527504675#L661
The same problem occurs in OSTRICH, which I still have to fix:
rdfostrich/ostrich-node#3
Failing builds:
The text was updated successfully, but these errors were encountered: