Notifier TLS options #420
Merged
Notifier TLS options #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra certificates for those behind a corporate proxy
- Reduce sendMailFunc logic to ensure message construction has correct code coverage - Update all test cases
|
@chriseppstein @ctrochalakis Please any one of you got time to have a look on this pull request? Our team met the same issue and really rely on this fix to move on. Many thanks |
vixns
pushed a commit
to vixns/Burrow
that referenced
this pull request
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to trust extra certificates for both SMTP and HTTP notifiers for those who need to accept self-signed certificates
Add option to skip verification on certs for both SMTP and HTTP notifiers
Reference issue
#412