Replace topicMap with topicPartitions in cluster module #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code use
topicMap
to maptopic
topartition count
,and partition ID is 0, 1, 2, ...partitionCount
- 1.However, if some partitions are broken (that is to say, these partitions have no leader), each time you call
getOffsets()
method,fetchMetadata
will be set, leading to the result thattopic-fresh
andoffset-fresh
these two configurations are meaningless.To solve this problem, I store each partition ID in a golang slice, when get metadata from the broker, check if partition has a leader, if true, then append it to the slice. I've initialized the slice's capacity with
partitionCount
, andappend
can be called at mostpartitionCount
times, so the capacity won't increase.Other issues:
errorTopics map[string]bool
ingenerateOffsetRequests()
is unnecessary, I've founderrorTopics
is used for some complex logic in older codes.executeTemplate()
in package notifier, the struct has a field named 'ID', but inconfig/default-http-post.tmpl
, it's{{.Id}}
.