Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for incorrect size estimation with range #154

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Fix for incorrect size estimation with range #154

merged 1 commit into from
Jan 7, 2022

Conversation

izzytwosheds
Copy link
Contributor

Duration estimation had a bug, it didn't work when media range started at non-zero and ended at Long.MAX_VALUE

ReallyVasiliy
ReallyVasiliy approved these changes Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@ReallyVasiliy ReallyVasiliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, I guess the only consideration since we're now clamping trim range to [0..duration], is track format must have KEY_DURATION. But I believe that'll always be the case right?

@izzytwosheds
Copy link
Contributor Author

It is possible not to have KEY_DURATION value, but that seems to be very rare. We should probably look into better way of handling this.

@izzytwosheds izzytwosheds merged commit d4822c3 into linkedin:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReallyVasiliy ReallyVasiliy ReallyVasiliy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izzytwosheds @ReallyVasiliy