Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional log to track unsatisfied requests #1372

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

jsjtzyy
Copy link
Contributor

@jsjtzyy jsjtzyy commented Feb 4, 2020

Print out more info of unsatisfied requests for investigation.

Print out more info of unsatisfied requests for investigation.
@jsjtzyy jsjtzyy self-assigned this Feb 4, 2020
@jsjtzyy jsjtzyy requested review from cgtz and removed request for justinlin-linkedin February 4, 2020 20:18
@codecov-io
Copy link

Codecov Report

Merging #1372 into master will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1372      +/-   ##
===========================================
+ Coverage     71.98%     72%   +0.02%     
- Complexity     6756    6758       +2     
===========================================
  Files           486     486              
  Lines         38353   38371      +18     
  Branches       4879    4883       +4     
===========================================
+ Hits          27609   27630      +21     
+ Misses         9410    9408       -2     
+ Partials       1334    1333       -1
Impacted Files Coverage Δ Complexity Δ
...ain/java/com.github.ambry/rest/ResponseStatus.java 95.34% <100%> (+0.11%) 26 <1> (+1) ⬆️
...va/com.github.ambry.rest/NettyResponseChannel.java 92.11% <88.23%> (+0.07%) 123 <4> (+5) ⬆️
...a/com.github.ambry.network/SSLBlockingChannel.java 75.67% <0%> (-5.41%) 4% <0%> (ø)
.../java/com.github.ambry.router/DeleteOperation.java 93.43% <0%> (-1.46%) 44% <0%> (-1%)
...c/main/java/com.github.ambry.network/Selector.java 78.21% <0%> (-1.05%) 77% <0%> (-1%)
...src/main/java/com.github.ambry.commons/BlobId.java 93.05% <0%> (-0.35%) 73% <0%> (-1%)
...ls/src/main/java/com.github.ambry.utils/Utils.java 78.54% <0%> (-0.31%) 122% <0%> (-1%)
...in/java/com.github.ambry.store/BlobStoreStats.java 70.62% <0%> (-0.21%) 103% <0%> (ø)
...java/com.github.ambry.network/SSLTransmission.java 71.38% <0%> (+0.3%) 76% <0%> (-1%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40eaf2...f3a2628. Read the comment docs.

*/
private void logUnsatisfiedRequest(Map<PerformanceIndex, Long> requestPerfToCheck) {
StringBuilder sb = new StringBuilder();
sb.append("Unsatisfied request: ").append(request.getUri()).append(" method=").append(request.getRestMethod());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"; method=" and say uri=request.getUri() to match the other key value pairs

sb.append("; blob size=").append((String) blobSize);
}
for (Map.Entry<PerformanceIndex, Long> entry : requestPerfToCheck.entrySet()) {
sb.append("; ").append(entry.getKey().toString()).append(": ").append(entry.getValue());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change ": " to "=" to match other key value pairs

@cgtz cgtz merged commit edfa224 into linkedin:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants