[DR] Compute CRC for backup recovery and verification #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambry-server/src/main/java/com/github/ambry/server/AmbryRequests.java
Outdated
Show resolved
Hide resolved
ambry-server/src/main/java/com/github/ambry/server/AmbryRequests.java
Outdated
Show resolved
Hide resolved
| @@ -241,6 +245,13 @@ private void fetchDataFromReadSet(MessageFormatMetrics metrics) throws MessageFo | |||
| } | |||
| } | |||
|
|
|||
| public long getBlobCRCOffset(MessageReadSet messages, int idx) throws MessageFormatException, IOException { | |||
There was a problem hiding this comment.
there is a better way to know the offset of CRC. When you call store.get(storeKeys, storeGetOptions), it returns a MessageReadSet and a list of MessageInfo. In this case, we only have one MessageInfo and one MessageReadSet. The MessageInfo's getSize() would return the size of this entire message, what we are trying to get is the crc of this message. As long as we know the message size, we can just do MessageInfo.getSize() - MessageFormatRecord.Crc_Size. Something like that.
So you don't really need to have a new method to get the crc offset.
ambry-server/src/main/java/com/github/ambry/server/AmbryRequests.java
Outdated
Show resolved
Hide resolved
| long crcOffset = msgFmt.getBlobCRCOffset(rdset, 0); // index = 0, as we have 1 msg | ||
| rdset.doPrefetch(0, crcOffset, 8); // crc is 8 bytes | ||
| long crc = rdset.getPrefetchedData(0).getLong(0); | ||
| newMsgInfo = new MessageInfo(crc, minfo); |
There was a problem hiding this comment.
We have to release the prefetched data buffer.
rdset.getPrefetchedData(0).release()
ambry-api/src/main/java/com/github/ambry/store/MessageInfo.java
Outdated
Show resolved
Hide resolved
ambry-server/src/main/java/com/github/ambry/server/AmbryRequests.java
Outdated
Show resolved
Hide resolved
justinlin-linkedin
approved these changes
May 23, 2024
snalli
changed the title
justinlin-linkedin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.