Allow SamzaPipelineLifeCycleListener to update configs #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnzng
reviewed
Apr 4, 2024
| @@ -111,7 +111,7 @@ public Config build() { | |||
|
|
|||
| validateConfigs(options, config); | |||
|
|
|||
| return new MapConfig(config); | |||
| return new HashMap<>(config); | |||
There was a problem hiding this comment.
The config is already a HashMap, we don't need new HashMap<> again.
private final Map<String, String> config = new HashMap<>();
There was a problem hiding this comment.
Some part of the code might return a ImmutableMap, so this is to prevent the output being non-deterministic. The listener will always have a mutable config map to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding ConfigPipelineOptions, Samza has issues serializing the options due to the size limit. This patch allows the listener to update the serialization config to avoid this limit.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.