Make the Throughput based assignment and task estimation based on partition assignment configurable. #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull latest
…ation configurable in Strategy
jzakaryan
approved these changes
Jun 28, 2021
| DEFAULT_ENABLE_THROUGHPUT_BASED_PARTITION_ASSIGNMENT); | ||
| _enablePartitionNumBasedTaskCountEstimation = props.getBoolean(CFG_ENABLE_PARTITION_NUM_BASED_TASK_COUNT_ESTIMATION, | ||
| DEFAULT_ENABLE_PARTITION_NUM_BASED_TASK_COUNT_ESTIMATION); | ||
|
|
| } | ||
|
|
||
| private void testValidThroughputBasedPartitionAssignmentPath(boolean enablePartitionCountBasedEstimation) { | ||
| PartitionThroughputProvider mockProvider = mock(PartitionThroughputProvider.class); |
There was a problem hiding this comment.
I created a test case like this one to verify metrics in #840. We need to leave just one by merging them.
| @@ -247,6 +276,63 @@ public void updatesNumTasksAndThrowsExceptionWhenNoSufficientTasksTest() { | |||
| Assert.assertEquals(numTasks2, 2); | |||
| } | |||
|
|
|||
| @Test | |||
| public void elasticTaskCountEnabledPathTest() { | |||
| testValidThroughputBasedPartitionAssignmentPath(true); | |||
There was a problem hiding this comment.
Feel free to ignore this. I don't see this making code more readable. It's a preference, but I'd rather have duplicate code in tests that's easy to follow. Nested calls add structural complexity.
shrinandthakkar
approved these changes
Jun 29, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…ation configurable in Strategy (linkedin#841) It is important to be able to enable/disable task estimation based on partition count or throughput based assignment to ensure that we can rollback or disable a feature if we have any issue in production. Along with this, fixing an issue where if the task estimated is same as minTask, it does not get saved in the zookeeper and needs extra iteration after it throws exception, which we can easily skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to be able to enable/disable task estimation based on partition count or throughput based assignment to ensure that we can rollback or disable a feature if we have any issue in production.
Along with this, fixing an issue where if the task estimated is same as minTask, it does not get saved in the zookeeper and needs extra iteration after it throws exception, which we can easily skip.