Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the DatabaseChunkedReader to take the Connection as input rather than the DataSource #850

Merged
merged 2 commits into from Aug 19, 2021

Conversation

somandal
Copy link
Collaborator

Currently the DatabaseChunkedReader takes a DataSource as input and calls its getConnection() function to obtain a connection to the DB. In the release resources code path, it does not clean up this Connection object, and this is potentially a leak and should be closed. The way we use the DatabaseChunkedReader in Oracle bootstrap is that we reuse the same DataSource for seeding multiple tables. Thus we can potentially expect the Oracle bootstrap task to know when it no longer needs the Connection object and close it. This would require passing the Connection object to the DatabaseChunkedReader instead of the DataSource.

Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.

Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md

Copy link
Collaborator

@DEEPTHIKORAT DEEPTHIKORAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@atoomula atoomula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@somandal somandal merged commit a23209c into linkedin:master Aug 19, 2021
@somandal somandal deleted the db-chunked-reader branch August 19, 2021 15:39
vmaheshw pushed a commit to vmaheshw/brooklin that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants