Update the DatabaseChunkedReader to take the Connection as input rather than the DataSource #850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
DatabaseChunkedReader
takes aDataSource
as input and calls itsgetConnection()
function to obtain a connection to the DB. In the release resources code path, it does not clean up thisConnection
object, and this is potentially a leak and should be closed. The way we use theDatabaseChunkedReader
in Oracle bootstrap is that we reuse the sameDataSource
for seeding multiple tables. Thus we can potentially expect the Oracle bootstrap task to know when it no longer needs theConnection
object and close it. This would require passing theConnection
object to theDatabaseChunkedReader
instead of theDataSource
.Important: DO NOT REPORT SECURITY ISSUES DIRECTLY ON GITHUB.
For reporting security issues and contributing security fixes,
please, email security@linkedin.com instead, as described in
the contribution guidelines.
Please, take a minute to review the contribution guidelines at:
https://github.com/linkedin/Brooklin/blob/master/CONTRIBUTING.md