Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit START/END log events for CoordinatorEvent operations #936

Merged
merged 1 commit into from
May 30, 2023

Conversation

ehoner
Copy link
Collaborator

@ehoner ehoner commented May 22, 2023

Operations performed by the Leader should create start/stop log pairs. These are helpful when investigating issues related to CoordinatorEvent processing. For each method corresponding to an event, the start and stop logs should begin on entry and end just before exit. The changes are itemized below according to event.

  • CoordinatorEvent / handleEvent:
    • Add "END" log to precondition/early return.
  • LEADER_DO_ASSIGNMENT
    • Add start and end.
    • Existing start and end capture timing only for assignment calculation. Activity before and after are not included.
  • HANDLE_ADD_OR_DELETE_DATASTREAM
    • Add start and end.
  • LEADER_PARTITION_MOVEMENT
    • Add start and end.

@ehoner ehoner merged commit c449757 into master May 30, 2023
1 check passed
@ehoner ehoner deleted the DATAPIPES-26639 branch May 30, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants