Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect RF violations for topics having targetReplicationFactor with topicReplicationFactorMargin violation #1637

Merged
merged 2 commits into from Jul 29, 2021

Conversation

efeg
Copy link
Collaborator

@efeg efeg commented Jul 29, 2021

This PR resolves #1565.

@efeg efeg requested a review from zornhsu July 29, 2021 19:27
Copy link
Contributor

@zornhsu zornhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the detecting feature, Efe! I left some comments below.

@efeg efeg merged commit d3d0f63 into linkedin:master Jul 29, 2021
efeg added a commit to efeg/cruise-control that referenced this pull request Jul 29, 2021
efeg added a commit to efeg/cruise-control that referenced this pull request Jul 29, 2021
@efeg efeg deleted the feat/rf branch October 5, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect RF violations for topics having targetReplicationFactor with topicReplicationFactorMargin violation
2 participants