Improvement and clean up. #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
becketqin
commented
Oct 5, 2017
•
becketqin
commented
- Bumped Kafka dependency to 0.10.2.1. So broker version 0.10.0 and above would work.
- Removed test harness classes. Just depend on li-apache-kafka-clients instead.
- Added separate configurations for the metrics reporter producer.
- Added the missing sasl configs.
…ocol. remove test harness classes to depend on li-apache-kafka-clients
…s for the metrics reporter producer.
smccauliff
previously requested changes
Oct 5, 2017
| @@ -85,30 +86,36 @@ public void close() { | |||
|
|
|||
| @Override | |||
| public void configure(Map<String, ?> configs) { | |||
| String bootstrapServers = (String) configs.get(CRUISE_CONTROL_METRICS_REPORTER_BOOTSTRAP_SERVERS); | |||
| if (bootstrapServers == null) { | |||
| Properties producerProps = CruiseControlMetricsReporterConfigs.parseConfigMap(configs); | |||
There was a problem hiding this comment.
If CruiseControlMetricsRepoterConfigs just extended from the Kafka configs class it would be easy to put all this default logic into that class. No?
radai-rosenblatt
approved these changes
Oct 5, 2017
becketqin
added a commit
that referenced
this pull request
Oct 19, 2017
1. Bumped Kafka dependency to 0.10.2.1. So broker version 0.10.0 and above would work. 2. Removed test harness classes. Just depend on li-apache-kafka-clients instead. 3. Added separate configurations for the metrics reporter producer. 4. Added the missing sasl configs. Conflicts: build.gradle
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.