add annotation proto schemas #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybz1013
added a commit
to ybz1013/datahub-gma
that referenced
this pull request
May 20, 2024
This reverts commit a5c5690.
ybz1013
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With metatadata-models migrated to proto, new data schemas to be added in proto needs to have native typesafe proto options as the pegasus options are not allowed on new protos.
Proto schema rules reference: https://solid-adventure-352gm28.pages.github.io/docs/proto_guide/proto_data_api_modeling
Testing Done
./gradlew build
proto schema validation with internal tools
Checklist