changed asynch call to future/blocking #352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talMemoryBytesSpilled metric) (linkedin#310)
…equires stages/failedTasks Rest API) (linkedin#288)
…eakJvmUsedMemory metric) (linkedin#318)
…kUnifiedMemory metric) (linkedin#281)
…Custom SHS - Requires peakJvmUsedMemory metric) (linkedin#287)
Separated out Driver checks into a separate Driver Metrics heuristic: Checks driver configurations, driver GC time and JVM used memory.
akshayrai
suggested changes
Mar 19, 2018
| @@ -94,38 +92,41 @@ class SparkFetcher(fetcherConfigurationData: FetcherConfigurationData) | |||
| Success(data) | |||
| }, | |||
| e => { | |||
| logger.error(s"Failed fetching data for ${appId}", e) | |||
| logger.error(s"Failed fetching data for ${appId}") | |||
There was a problem hiding this comment.
As discussed, retain the exception message and turn this into a warning message.
| @@ -16,11 +16,9 @@ | |||
|
|
|||
| package com.linkedin.drelephant.spark.fetchers | |||
|
|
|||
| import scala.async.Async | |||
There was a problem hiding this comment.
Can you update the description of this PR with the motivation behind this change?
akshayrai
force-pushed
the
customSHSWork
branch
2 times, most recently
from
a49a0f8
to
7dfe640
Compare
akshayrai
force-pushed
the
customSHSWork
branch
from
f333c3f
to
3436b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.