Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http://yui.github.io/yuicompressor/ (CQ content managment) can't minify full version #659

Closed
bludrate opened this issue May 7, 2015 · 4 comments · Fixed by #660
Closed

Comments

@bludrate
Copy link

bludrate commented May 7, 2015

1304 line. dust v. 2.7.1
peg$c102 = function(char) {return char},

char - is reserved word

@smfoote
Copy link
Contributor

smfoote commented May 7, 2015

Since the line in question is coming from parser.js, which is generated by PEG.js (and therefore out of our control), and a minified version of Dust full is already available, I'm going to close this issue.

@smfoote smfoote closed this as completed May 7, 2015
@sethkinast
Copy link
Contributor

We can open an issue upstream instead of just closing his issue

On Thu, May 7, 2015, 7:25 AM Steven notifications@github.com wrote:

Closed #659 #659.


Reply to this email directly or view it on GitHub
#659 (comment).

@sethkinast
Copy link
Contributor

But in this case it's not even coming from upstream; it's coming from our compiled grammar.

@sethkinast
Copy link
Contributor

@bludrate if you need to work around this issue before we release a new version, it will work fine to just rename the char variable-- it's not used anywhere else.

sethkinast added a commit that referenced this issue May 7, 2015
Grammar: s/char/character/ to avoid using a reserved name

Closes #659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants