Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.4.0 in dist so that docs are correct #9

Merged
merged 1 commit into from Apr 20, 2012
Merged

Update to 0.4.0 in dist so that docs are correct #9

merged 1 commit into from Apr 20, 2012

Conversation

kmiyashiro
Copy link
Contributor

$idx is broken in @if conditions in 0.3.0. The dist file is out of date on github, not sure if 0.4.0 is supposed to be ready, but it passes all tests.

@vybs
Copy link
Contributor

vybs commented Apr 20, 2012

We will remove the dist file and it should not be checked into source IMO

Second, 0.4.0 is ready, we use it here @linkedin

I will clean up the make file to compile the latest to the dist

@kmiyashiro
Copy link
Contributor Author

By remove the dist file, do you mean remove the dist folder completely? That would mean people who don't know what make is and any Windows user wouldn't be able to make a build (without cygwin). I think stable builds should definitely be checked in the repo, that's how most client-side js libs are today.

@vybs
Copy link
Contributor

vybs commented Apr 20, 2012

See the point !

Sent from my iPad

On Apr 19, 2012, at 9:21 PM, Kelly Miyashiroreply@reply.github.com wrote:

By remove the dist file, do you mean remove the dist folder completely? That would mean people who don't know what make is and any Windows user wouldn't be able to make a build (without cygwin). I think stable builds should definitely be checked in the repo, that's how most client-side js libs are today.


Reply to this email directly or view it on GitHub:
#9 (comment)

vybs added a commit that referenced this pull request Apr 20, 2012
Update to 0.4.0 in dist so that docs are correct
@vybs vybs merged commit 7c87e28 into linkedin:master Apr 20, 2012
prashn64 pushed a commit to prashn64/dustjs that referenced this pull request Jan 27, 2015
Add more Dust Template API documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants