OOB Sender validation tweaks #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests which confirm that specifying invalid role/target 400. - Log the sender reject message in the API logs so we can easier debug this without needing to dig into sender logs. - Add checks in notifications endpoint that require either body or a template to be specified, as without both the message will not be able to be generate and then sent.
This way we can test against obviously bad roles like fakerol123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make OOB sending more stringent and add tests
Address #128
Add tests which confirm that specifying invalid role/target 400.
Log the sender reject message in the API logs so we can easier debug
this without needing to dig into sender logs.
Add checks in notifications endpoint that require either body
or a template to be specified, as without both the message will
not be able to be generate and then sent.
Also fix quota logging