Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on paramiko #12

Merged
merged 2 commits into from
Jul 5, 2016
Merged

Remove dependency on paramiko #12

merged 2 commits into from
Jul 5, 2016

Conversation

toddpalino
Copy link
Contributor

This is to resolve Issue #10.

Paramiko doesn't get us much of anything in this app. In fact, it probably slows things down with the need to load the entire host keys file. This swaps out paramiko for just making subprocess calls to the ssh CLI.

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage decreased (-0.2%) to 99.345% when pulling ae0628c on toddpalino:master into 9f85237 on linkedin:master.

@codecov-io
Copy link

Current coverage is 99.34%

Merging #12 into master will decrease coverage by 0.22%

@@             master        #12   diff @@
==========================================
  Files            29         29          
  Lines           921        916     -5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            917        910     -7   
- Misses            4          6     +2   
  Partials          0          0          

Powered by Codecov. Last updated by 9f85237...ae0628c

@toddpalino toddpalino merged commit 091ca04 into linkedin:master Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants