-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Remove @LegacyFileIO and Make DelegationRefreshToken use new cluster.yaml #100
Conversation
cc: @ctrezzo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there coordination required when picking up this change internally, since you are making some config changes ?
...ain/java/com/linkedin/openhouse/cluster/storage/hdfs/HdfsDelegationTokenRefresherConfig.java
Show resolved
Hide resolved
...lcatalog/src/main/java/com/linkedin/openhouse/internal/catalog/OpenHouseInternalCatalog.java
Show resolved
Hide resolved
...ain/java/com/linkedin/openhouse/cluster/storage/hdfs/HdfsDelegationTokenRefresherConfig.java
Show resolved
Hide resolved
...ain/java/com/linkedin/openhouse/cluster/storage/hdfs/HdfsDelegationTokenRefresherConfig.java
Show resolved
Hide resolved
...ain/java/com/linkedin/openhouse/cluster/storage/hdfs/HdfsDelegationTokenRefresherConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for answering the questions. lgtm
Summary
Let's start refactoring the old code out 🙌
There are two refactors:
DelegationTokenRefresher
should use the new cluster.yamlThere are no major changes to code otherwise.
Changes
Testing Done
✅ Added unit tests for token refresh that were missing before 🥳
✅ mint build and existing tests pass
✅ manually tested token refresh code in docker setup
✅ manually tested fileIO code in docker setup