Deprecate Tasks.par(...) for safer alternative Task.par(...) that does not throw IllegalArgumentException on empty collection. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not throw IllegalArgumentException on empty collection.
jodzga
reviewed
Feb 24, 2017
| * {@link com.linkedin.parseq.ParTask#getTasks()} or | ||
| * {@link com.linkedin.parseq.ParTask#getSuccessful()} to get results in this | ||
| * case. | ||
| * <p> |
There was a problem hiding this comment.
Document behavior when when Iterable is empty.
| * | ||
| * @param tasks the tasks to run in parallel | ||
| * @return The results of the tasks | ||
| * @deprecated As of 2.0.0, replaced by {@link Task#par(Iterable) Task.par} |
There was a problem hiding this comment.
Document difference in behavior between this method and the Task.par(Iterable)
ssodhanilinkedin
approved these changes
Feb 24, 2017
|
Great work on this! Can't wait to see this get merged, we just had a production bug because of the old behavior. Thanks for taking initiative and putting up a fix so quickly. |
yborovikov
reviewed
Feb 28, 2017
| @@ -63,6 +68,11 @@ public ParTaskImpl(final String name, final Iterable<? extends Task<? extends T> | |||
| protected Promise<List<T>> run(final Context context) throws Exception { | |||
| final SettablePromise<List<T>> result = Promises.settable(); | |||
|
|
|||
| if (_tasks.isEmpty()) { | |||
| result.done(Collections.<T>emptyList()); | |||
There was a problem hiding this comment.
maybe even return Promises.value(Collections.<T>emptyList());
and move it before line 69?
This was referenced Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Tasks.par(...) for safer alternative Task.par(...) that does not throw IllegalArgumentException on empty collection.