Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting a calendar event list with Exchange 14.2.247.0 … #24

Merged
merged 3 commits into from
Oct 31, 2014
Merged

Fix getting a calendar event list with Exchange 14.2.247.0 … #24

merged 3 commits into from
Oct 31, 2014

Conversation

nud
Copy link

@nud nud commented Oct 27, 2014

The SOAP query was returing the following error:

The request failed schema validation: The 'EndDate' attribute is
invalid - The value '2014-10-28' is invalid according to its
datatype 'http://www.w3.org/2001/XMLSchema:dateTime'; - The string
'2014-10-28' is not a valid XsdDateTime value.

The fix is simply to use the DATETIME format instead of the DATE format,
as advised in the MSDN page of the CalendarView element.

http://msdn.microsoft.com/en-us/library/office/aa564515%28v=exchg.140%29.aspx

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 21d2098 on nud:fix-list-events into 3cdb335 on linkedin:master.

@catermelon
Copy link
Contributor

Looks great, thank you so much for the contribution. Would you mind writing a quick test around this, so we don't regress?

Previously, we let ElementTree pick its own prefix, and it took 'ns0'.
This is much needed when you get 500's, which usually come with an
explanation on why the request was not accepted.
The SOAP query was returing the following error:

    The request failed schema validation: The 'EndDate' attribute is
    invalid - The value '2014-10-28' is invalid according to its
    datatype 'http://www.w3.org/2001/XMLSchema:dateTime' - The string
    '2014-10-28' is not a valid XsdDateTime value.

The fix is simply to use the DATETIME format instead of the DATE format,
as advised in the MSDN page of the CalendarView element.

http://msdn.microsoft.com/en-us/library/office/aa564515%28v=exchg.140%29.aspx
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 15cff55 on nud:fix-list-events into 623f0af on linkedin:master.

@nud
Copy link
Author

nud commented Oct 30, 2014

Rebased on top on master, and test added.

catermelon pushed a commit that referenced this pull request Oct 31, 2014
Fix getting a calendar event list with Exchange 14.2.247.0 …
@catermelon catermelon merged commit 894c569 into linkedin:master Oct 31, 2014
@catermelon
Copy link
Contributor

Awesome, thank you so much! Is this blocking you? I can put out a patch release. If not, I'll wait for a few more features to roll in.

@nud
Copy link
Author

nud commented Nov 6, 2014

No it's not, I was implementing something else and used this as a test.

Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants