Skip to content

Commit

Permalink
Update default values to match configs
Browse files Browse the repository at this point in the history
Default values of several properties were changed recently. Updating the default values in code to match the configs.

RB=1290394
G=si-core-reviewers
R=pchen,dhoa
A=dhoa
  • Loading branch information
cx-super committed May 2, 2018
1 parent 57cc704 commit efffab8
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 11 deletions.
13 changes: 13 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
20.0.24
-------

20.0.23
-------
(RB=1290394)
Update default values of the following properties:
DEFAULT_RAMP_FACTOR = 2.0;
DEFAULT_HIGH_WATER_MARK = 600;
DEFAULT_LOW_WATER_MARK = 200;
DEFAULT_DOWN_STEP = 0.05;
DEFAULT_MIN_CALL_COUNT = 1;
DEFAULT_HIGH_LATENCY = Time.milliseconds(400);
DEFAULT_LOW_LATENCY = Time.milliseconds(200);
DEFAULT_REQUEST_TIMEOUT = 1000;

20.0.22
-------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,12 @@ public class DegraderLoadBalancerStrategyConfig

public static final Clock DEFAULT_CLOCK = SystemClock.instance();
public static final double DEFAULT_INITIAL_RECOVERY_LEVEL = 0.01;
public static final double DEFAULT_RAMP_FACTOR = 1.0;
public static final double DEFAULT_RAMP_FACTOR = 2.0;
public static final long DEFAULT_UPDATE_INTERVAL_MS = 5000L;
public static final boolean DEFAULT_UPDATE_ONLY_AT_INTERVAL = false;
public static final int DEFAULT_POINTS_PER_WEIGHT = 100;
// I think that these two will require tuning, based upon the service SLA.
// Using degrader's defaults.
public static final double DEFAULT_HIGH_WATER_MARK = 3000;
public static final double DEFAULT_LOW_WATER_MARK = 500;
public static final double DEFAULT_HIGH_WATER_MARK = 600;
public static final double DEFAULT_LOW_WATER_MARK = 200;

// even though the degrader has it's own stepUp and stepDown, we need new knobs to turn for
// the globalStepUp and globalStepDown drop rates.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ public class DegraderImpl implements Degrader
public static final Double DEFAULT_MAX_DROP_RATE = 1.00;
public static final long DEFAULT_MAX_DROP_DURATION = Time.milliseconds(60000);
public static final Double DEFAULT_UP_STEP = 0.20;
public static final Double DEFAULT_DOWN_STEP = 0.20;
public static final Integer DEFAULT_MIN_CALL_COUNT = 10;
public static final long DEFAULT_HIGH_LATENCY = Time.milliseconds(3000);
public static final long DEFAULT_LOW_LATENCY = Time.milliseconds( 500);
public static final Double DEFAULT_DOWN_STEP = 0.05;
public static final Integer DEFAULT_MIN_CALL_COUNT = 1;
public static final long DEFAULT_HIGH_LATENCY = Time.milliseconds(400);
public static final long DEFAULT_LOW_LATENCY = Time.milliseconds(200);
public static final Double DEFAULT_HIGH_ERROR_RATE = 1.1;
public static final Double DEFAULT_LOW_ERROR_RATE = 1.1;
public static final long DEFAULT_HIGH_OUTSTANDING = Time.milliseconds(10000);
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version=20.0.22
version=20.0.23
sonatypeUsername=please_set_in_home_dir_if_uploading_to_maven_central
sonatypePassword=please_set_in_home_dir_if_uploading_to_maven_central
org.gradle.configureondemand=true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public class HttpClientFactory implements TransportClientFactory

public static final int DEFAULT_POOL_WAITER_SIZE = Integer.MAX_VALUE;
public static final int DEFAULT_POOL_SIZE = 200;
public static final int DEFAULT_REQUEST_TIMEOUT = 10000;
public static final int DEFAULT_REQUEST_TIMEOUT = 1000;
public static final int DEFAULT_GRACEFUL_SHUTDOWN_TIMEOUT = 30000;
public static final int DEFAULT_IDLE_TIMEOUT = 25000;
public static final int DEFAULT_SSL_IDLE_TIMEOUT = (2 * 3600 + 60 * 55) * 1000; // 2h 55m
Expand Down

0 comments on commit efffab8

Please sign in to comment.