Generate APIs to build field mask as a Map directly. #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikbalasub
requested review from
evanw555,
aman1309,
BrianPin,
junchuanwang and
nickibi
karthikbalasub
force-pushed
the
feature/mask_builder
branch
from
d690060
to
142919d
Compare
the fields parameter.
karthikbalasub
force-pushed
the
feature/mask_builder
branch
from
142919d
to
c5c1901
Compare
| @@ -47,14 +44,14 @@ | |||
| * The semantics of applying a MaskTree to a DataMap are documented in {@link com.linkedin.data.transform.DataComplexProcessor} | |||
| */ | |||
|
|
|||
| public class MaskTree | |||
| public class MaskTree extends FieldMask | |||
There was a problem hiding this comment.
Do you think we should come up a better name? MaskMap or something? I feel MaskTree are not necessarily superset of FieldMask by its name. I felt that it is only after we connect it to the request builder or data template that we bring the concept of "field".
There was a problem hiding this comment.
MaskMap was my first choice :) and renamed it to FieldMask as this is actually storing mask for the field tree.
I see your point that this can represent any generic mask. I can rename it back.
generator/src/main/java/com/linkedin/pegasus/generator/PegasusDataTemplateGenerator.java
Show resolved
Hide resolved
generator/src/main/java/com/linkedin/pegasus/generator/JavaDataTemplateGenerator.java
Outdated
Show resolved
Hide resolved
generator/src/main/java/com/linkedin/pegasus/generator/JavaDataTemplateGenerator.java
Show resolved
Hide resolved
generator/src/main/java/com/linkedin/pegasus/generator/JavaDataTemplateGenerator.java
Outdated
Show resolved
Hide resolved
restli-client/src/test/java/com/linkedin/restli/internal/client/TestQueryParamsUtil.java
Outdated
Show resolved
Hide resolved
| @@ -23,6 +23,7 @@ | |||
| public static final String WILDCARD = "$*"; | |||
| public static final String START = "$start"; | |||
| public static final String COUNT = "$count"; | |||
| public static final int NUMBER_OF_ARRAY_ATTRIBUTES = 2; // start and count. | |||
There was a problem hiding this comment.
Sorry for my last comment. It might be better:
public static final Set<String> ARRAY_ATTRIBUTES = new HashSet<>(Arrays.asList(START, COUNT));
And then use ARRAY_ATTRIBUTES.size() in the code
junchuanwang
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated client APIs to accept the field mask as value for projection parameters.