Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PrestoSQL 333 #45

Merged
merged 1 commit into from
May 8, 2020
Merged

Upgrade to PrestoSQL 333 #45

merged 1 commit into from
May 8, 2020

Conversation

lxynov
Copy link
Contributor

@lxynov lxynov commented May 7, 2020

Some major changes:

Tests done:

  • ./gradlew build passes inside transportable-udfs-examples
  • Tested end-to-end with Presto 333 using one of the example UDFs array_fill. It works well

shardulm94
shardulm94 reviewed May 7, 2020
View reviewed changes
Copy link
Contributor

@shardulm94 shardulm94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Minor comment.
Also I observed that the patch file has some lines now above 120 chars. Just ensure that the patch adheres to code style guidelines of Presto.

docs/transport-udfs-presto.patch Outdated Show resolved Hide resolved
@lxynov
Upgrade to PrestoSQL 333
95a957a 
Some major changes:
 - `SqlFunction`, `SqlScalarFunction` and `ScalarFunctionImplementation` have evolved
   in trinodb/trino#1764
 - `Metadata::getScalarFunctionImplementation` evolved in trinodb/trino#1039
 - Type signature parser was moved to presto-main in trinodb/trino#1738
@lxynov
Copy link
Contributor Author

lxynov commented May 7, 2020

@shardulm94 Thanks for the review. I've updated the PR. Yeah 120 chars is not a strict enforcement in Presto but let's update to conform to it.

wmoustafa
wmoustafa approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@wmoustafa wmoustafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@wmoustafa wmoustafa merged commit 0961752 into linkedin:master May 8, 2020
@lxynov lxynov deleted the presto-333 branch May 8, 2020 17:51
wmoustafa pushed a commit that referenced this pull request Oct 12, 2021
@maluchari @shardulm94
@shipkit-org @SurenNihalani @lxynov @khaitranq @jjoyce0510 @raymondlam12 @curtiscwang @cwsteinbach @akshayrai @srramach @rzhang10 @kxu1026 @HotSushi
Rebasing master on top of transport-api-v1 (#94)
b0e9f17 
* Disable Jacoco for platform tests (#37)

* 0.0.46 release (previous 0.0.45) + release notes updated [ci skip]

* Fixed presto UDF patch broken link (#41)

Co-authored-by: Sushant Raikar <sraikar@sraikar-mn2.linkedin.biz>

* FileSystemUtils: remove an unreliable check for unit testing (#42)

Why: we don't need it

What changed: instead of checking configuration for hints on whether we
are unit testing, we trust the URI's protocol

Tests performed: ./gradlew build

* 0.0.47 release (previous 0.0.46) + release notes updated [ci skip]

* Presto: Pass custom configuration object when using FileSystemUtils (#43)

* 0.0.48 release (previous 0.0.47) + release notes updated [ci skip]

* Presto: Make ScalarFunctionImplementation state independent of StdUdfWrapper (#44)

* 0.0.49 release (previous 0.0.48) + release notes updated [ci skip]

* Upgrade to PrestoSQL 333 (#45)

Some major changes:
 - `SqlFunction`, `SqlScalarFunction` and `ScalarFunctionImplementation` have evolved
   in trinodb/trino#1764
 - `Metadata::getScalarFunctionImplementation` evolved in trinodb/trino#1039
 - Type signature parser was moved to presto-main in trinodb/trino#1738

* 0.0.50 release (previous 0.0.49) + release notes updated [ci skip]

* Add support for StdFloat, StdDouble, and StdBinary (#46)

* Introduce StdFloat, StdDouble, and StdBinary interfaces
* Add implementations of those interfaces in Avro, Hive, Presto, Spark, and Generic type systems
* Add examples of transport UDFs on those new types, and add tests for those UDFs
* Update documentation

* 0.0.51 release (previous 0.0.50) + release notes updated [ci skip]

* Allow users to override main and test source set names, output directories

* 0.0.52 release (previous 0.0.51) + release notes updated [ci skip]

* Empty commit to release new version

* Empty commit to release new version [ci skip-compare-publications]

* 0.0.53 release (previous 0.0.52) + release notes updated [ci skip]

* Plugin: Publish Presto thin jar which allows consumers to control dependency graph (#49)

* 0.0.54 release (previous 0.0.53) + release notes updated [ci skip]

* Hive: Struct data should not be converted to object array during StdStruct creation (#50)

* Remove slf4j-log4j12 from Transport dependency graph (#51)

* Bump shipkit (#54)

* 0.0.55 release (previous 0.0.54) + release notes updated [ci skip]

* Fix test SQL generation for binary inputs (#55)

* 0.0.56 release (previous 0.0.55) + release notes updated [ci skip]

* Spark: Create index-based iterator for non-mutable map keySet and values access (#58)

* 0.0.57 release (previous 0.0.56) + release notes updated [ci skip]

* Avro: Support simple union schemas (#60)

* 0.0.58 release (previous 0.0.57) + release notes updated [ci skip]

* Support conversion of String type to Utf8 in AvroWrapper (#61)

* 0.0.59 release (previous 0.0.58) + release notes updated [ci skip]

* Add Avro ENUM read support and fix String bug (#62)

Co-authored-by: Raymond Lam <ralam@linkedin.com>

* 0.0.60 release (previous 0.0.59) + release notes updated [ci skip]

* Build: Fail if there are checkstyle violations (#64)

- Change the Checkstyle severity level from warning to error
- Eliminate all existing checkstyle violations

Co-authored-by: Carl Steinbach <cwsteinbach@gmail.com>

* 0.0.61 release (previous 0.0.60) + release notes updated [ci skip]

* Add travis-build.sh for pre-commit testing from command line (#65)

* Add travis-build.sh for pre-commit testing from command line

* Fix name of build file in comment

Co-authored-by: Carl Steinbach <cwsteinbach@gmail.com>
Co-authored-by: Shardul Mahadik <smahadik@linkedin.com>

* Upgrade to Gradle 6.7 (#67)

* Support builds with platform specific JDK (#69)

* Bump Avro dependency to 1.10.2 (from 1.7.7). (#71)

There doesn't seem to be any impact to the code. gradle build passes.

* Migrate from PrestoSQL to Trino  (#68)

* Automate artifact publication to Maven Central (#72)

* Update ci.yml java version to 8 (#77)

skip release

* Fix org.pentaho:pentaho-aggdesigner-algorithm sunset problem (#78)

* Remove travis build in favor of github actions (#87)

* Add scala_2.11 and scala_2.12 support (#85)

* Update ci.yml to also build the udf-examples folder (#90)

Co-authored-by: Malini Mahalakshmi Venkatachari <malvenkatachari@linkedin.com>

* Fix running multiple builds in run step in workflow action (#92)

Co-authored-by: Malini Mahalakshmi Venkatachari <malvenkatachari@linkedin.com>

* A solution to fix running multiple UDFs in Spark issue (#93)

Co-authored-by: Kai Xu <kxu@kxu-mn3.linkedin.biz>

Co-authored-by: Shardul Mahadik <smahadik@linkedin.com>
Co-authored-by: shipkit-org <shipkit.org@gmail.com>
Co-authored-by: Sushant Raikar <sraikar@wish.com>
Co-authored-by: Sushant Raikar <sraikar@sraikar-mn2.linkedin.biz>
Co-authored-by: Suren Nihalani <1093911+SurenNihalani@users.noreply.github.com>
Co-authored-by: Xingyuan Lin <xinlin@linkedin.com>
Co-authored-by: Khai Tran <46727493+khaitranq@users.noreply.github.com>
Co-authored-by: John Joyce <jjoyce6@nd.edu>
Co-authored-by: Raymond <13109642+raymondlam12@users.noreply.github.com>
Co-authored-by: curtiscwang <cwang89@gmail.com>
Co-authored-by: Raymond Lam <ralam@linkedin.com>
Co-authored-by: Carl Steinbach <cwsteinbach+github@gmail.com>
Co-authored-by: Carl Steinbach <cwsteinbach@gmail.com>
Co-authored-by: Akshay Rai <akrai@linkedin.com>
Co-authored-by: Sreeram Ramachandran <sramachandran@linkedin.com>
Co-authored-by: Raymond Zhang <razhang@linkedin.com>
Co-authored-by: KAI XU <kxu@linkedin.com>
Co-authored-by: Sushant Raikar <sraikar@linkedin.com>
Co-authored-by: Malini Mahalakshmi Venkatachari <malvenkatachari@linkedin.com>
Co-authored-by: Kai Xu <kxu@kxu-mn3.linkedin.biz>
wmoustafa pushed a commit that referenced this pull request Oct 13, 2021
@lxynov @wmoustafa
Upgrade to PrestoSQL 333 (#45)
1bba76e 
Some major changes:
 - `SqlFunction`, `SqlScalarFunction` and `ScalarFunctionImplementation` have evolved
   in trinodb/trino#1764
 - `Metadata::getScalarFunctionImplementation` evolved in trinodb/trino#1039
 - Type signature parser was moved to presto-main in trinodb/trino#1738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shardulm94 shardulm94 shardulm94 left review comments

@wmoustafa wmoustafa wmoustafa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lxynov @shardulm94 @wmoustafa