-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebasing master on top of transport-api-v1 #94
Merged
wmoustafa
merged 49 commits into
linkedin:transport-api-v1
from
maluchari:transport-api-v2
Oct 12, 2021
Merged
Rebasing master on top of transport-api-v1 #94
wmoustafa
merged 49 commits into
linkedin:transport-api-v1
from
maluchari:transport-api-v2
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sushant Raikar <sraikar@sraikar-mn2.linkedin.biz>
…n#42) Why: we don't need it What changed: instead of checking configuration for hints on whether we are unit testing, we trust the URI's protocol Tests performed: ./gradlew build
Some major changes: - `SqlFunction`, `SqlScalarFunction` and `ScalarFunctionImplementation` have evolved in trinodb/trino#1764 - `Metadata::getScalarFunctionImplementation` evolved in trinodb/trino#1039 - Type signature parser was moved to presto-main in trinodb/trino#1738
* Introduce StdFloat, StdDouble, and StdBinary interfaces * Add implementations of those interfaces in Avro, Hive, Presto, Spark, and Generic type systems * Add examples of transport UDFs on those new types, and add tests for those UDFs * Update documentation
Co-authored-by: Raymond Lam <ralam@linkedin.com>
- Change the Checkstyle severity level from warning to error - Eliminate all existing checkstyle violations Co-authored-by: Carl Steinbach <cwsteinbach@gmail.com>
…n#65) * Add travis-build.sh for pre-commit testing from command line * Fix name of build file in comment Co-authored-by: Carl Steinbach <cwsteinbach@gmail.com> Co-authored-by: Shardul Mahadik <smahadik@linkedin.com>
There doesn't seem to be any impact to the code. gradle build passes.
skip release
Co-authored-by: Malini Mahalakshmi Venkatachari <malvenkatachari@linkedin.com>
Co-authored-by: Malini Mahalakshmi Venkatachari <malvenkatachari@linkedin.com>
Co-authored-by: Kai Xu <kxu@kxu-mn3.linkedin.biz>
wmoustafa
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update ref of transport-api-v1 so that it matches with that of master. This PR is the first step towards merging of type-safe-api changes.