Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client][internal] Fix tests related to PR#975 #995

Merged
merged 2 commits into from
May 21, 2024

Conversation

mynameborat
Copy link
Contributor

@mynameborat mynameborat commented May 20, 2024

Summary

How was this PR tested?

ran the failing tests locally in intellij and terminal

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@xunyin8
Copy link
Contributor

xunyin8 commented May 20, 2024

As we discussed offline testSNQuotaNotEnabled is the trouble maker here together with the fact that the SN read quota flag is only set during setUp() which is only annotated with BeforeClass. We need to reset the flag after each test.

@adamxchen
Copy link
Collaborator

They were not failing in the previous tests because they are flaky, correct?

xunyin8
xunyin8 previously approved these changes May 21, 2024
@mynameborat
Copy link
Contributor Author

They were not failing in the previous tests because they are flaky, correct?

@adamxchen There is some flakiness around testSNQuotaNotEnabled depending on the order of execution of tests in the class.

@mynameborat mynameborat merged commit bf00dac into linkedin:main May 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants