Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client][internal] Fix tests related to PR#975 #995

Merged
merged 2 commits into from
May 21, 2024
Merged

[client][internal] Fix tests related to PR#975 #995

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c17250c
[client][internal] Fix tests related to PR#975
May 20, 2024
1d70bbc
Fix flakiness in testSNReadQuotaNotEnabled
May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ntegrationTest/java/com/linkedin/venice/fastclient/FastClientGrpcServerReadQuotaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,10 @@ public void testGrpcServerReadQuota() throws Exception {
StoreMetadataFetchMode.SERVER_BASED_METADATA);
// Update the read quota to 1000 and make 500 requests, all requests should be allowed.
veniceCluster.useControllerClient(controllerClient -> {
TestUtils
.assertCommand(controllerClient.updateStore(storeName, new UpdateStoreQueryParams().setReadQuotaInCU(1000)));
TestUtils.assertCommand(
controllerClient.updateStore(
storeName,
new UpdateStoreQueryParams().setReadQuotaInCU(1000).setStorageNodeReadQuotaEnabled(true)));
});
for (int j = 0; j < 5; j++) {
for (int i = 0; i < recordCnt; i++) {
Expand Down
6 changes: 4 additions & 2 deletions ...est/java/com/linkedin/venice/fastclient/FastClientIndividualFeatureConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ public void testServerReadQuota() throws Exception {
StoreMetadataFetchMode.SERVER_BASED_METADATA);
// Update the read quota to 1000 and make 500 requests, all requests should be allowed.
veniceCluster.useControllerClient(controllerClient -> {
TestUtils
.assertCommand(controllerClient.updateStore(storeName, new UpdateStoreQueryParams().setReadQuotaInCU(1000)));
TestUtils.assertCommand(
controllerClient.updateStore(
storeName,
new UpdateStoreQueryParams().setReadQuotaInCU(1000).setStorageNodeReadQuotaEnabled(true)));
});
for (int j = 0; j < 5; j++) {
for (int i = 0; i < recordCnt; i++) {
Expand Down
3 changes: 2 additions & 1 deletion .../src/integrationtest/java/com/linkedin/venice/fastclient/grpc/VeniceGrpcEndToEndTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ public void cleanUp() {
public String writeData(String storeName) throws IOException {
// 1. Create a new store in Venice
cluster.getNewStore(storeName);
UpdateStoreQueryParams params = new UpdateStoreQueryParams().setStorageQuotaInByte(Store.UNLIMITED_STORAGE_QUOTA);
UpdateStoreQueryParams params = new UpdateStoreQueryParams().setStorageQuotaInByte(Store.UNLIMITED_STORAGE_QUOTA)
.setStorageNodeReadQuotaEnabled(true);

ControllerResponse updateStoreResponse = cluster.updateStore(storeName, params);
Assert.assertNull(updateStoreResponse.getError());
Expand Down
Loading