add ephemeral node creation throttled log message #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrantPSpencer
force-pushed
the
ephemeral-throttle-logs
branch
from
28edc73
to
40e80a5
Compare
desaikomal
approved these changes
Feb 7, 2024
rahulrane50
reviewed
Feb 8, 2024
| > ZooKeeperServer.getEphemeralNodesTotalByteLimit()) { | ||
| LOG.error(String.format("Rejecting ephemeral node creation for session %s, zxid %s, path %s.", |
There was a problem hiding this comment.
this may flood out logs. Let's do a controlled rollout for this.
rahulrane50
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add log message when server throttles ephemeral node creation due to byte limit exceeded.
Tests
Changes that Break Backward Compatibility (Optional)
N/A
Documentation (Optional)
N/A