You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HelloWorldIdentifierConfig.scala fails to compile. issue-type: bug scala version: 2.12.2 JVM: 8 steps to reproduce:
clone linkerd-examples
cd plugins
./sbt headerClassifier/assembly
Error log:
[error] /root/linkerd-official/linkerd-examples/plugins/header-classifier/src/main/scala/io/buoyant/http/identifiers/HelloWorldIdentifierConfig.scala:10: class HelloWorldIdentifierConfig needs to be abstract, since method newIdentifier in class HttpIdentifierConfig of type (prefix: com.twitter.finagle.Path, baseDtab: () => com.twitter.finagle.Dtab, routerParams: com.twitter.finagle.Stack.Params)io.buoyant.router.RoutingFactory.Identifier[com.twitter.finagle.http.Request] is not defined
[error] class HelloWorldIdentifierConfig extends HttpIdentifierConfig{
[error] ^
[error] /root/linkerd-official/linkerd-examples/plugins/header-classifier/src/main/scala/io/buoyant/http/identifiers/HelloWorldIdentifierConfig.scala:15: method newIdentifier overrides nothing.
[error] Note: the super classes of class HelloWorldIdentifierConfig contain the following, non final members named newIdentifier:
[error] def newIdentifier(prefix: com.twitter.finagle.Path,baseDtab: () => com.twitter.finagle.Dtab,routerParams: com.twitter.finagle.Stack.Params): io.buoyant.router.RoutingFactory.Identifier[com.twitter.finagle.http.Request]
[error] override def newIdentifier(prefix: Path, baseDtab: () => Dtab): Identifier[Request] = {
[error] ^
[error] two errors found
The text was updated successfully, but these errors were encountered:
HelloWorldIdentifierConfig.scala fails to compile.
issue-type: bug
scala version: 2.12.2
JVM: 8
steps to reproduce:
./sbt headerClassifier/assembly
Error log:
The text was updated successfully, but these errors were encountered: