Linkerd 1.4.3 #1987
Merged
Linkerd 1.4.3 #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
olix0r
reviewed
Jun 12, 2018
CHANGES.md
Outdated
| @@ -1,3 +1,12 @@ | |||
| ## 1.4.3 2018-06-12 | |||
|
|
|||
| This is a follow up release that includes diagnostic tracing for H2 requests. The feature was | |||
There was a problem hiding this comment.
spacing "that includes"
wording: "This follow up release includes". I'd drop the line after it about not making 1.4.2 (not useful in the changelog)
adleong
reviewed
Jun 12, 2018
CHANGES.md
Outdated
| @@ -1,3 +1,12 @@ | |||
| ## 1.4.3 2018-06-12 | |||
|
|
|||
| This is a follow up release that includes diagnostic tracing for H2 requests. The feature was | |||
There was a problem hiding this comment.
double space between "that" and "includes"
CHANGES.md
Outdated
| scheduled for version 1.4.2 but did not make it in time for the release. | ||
|
|
||
| Full release notes: | ||
|
|
There was a problem hiding this comment.
diagnostic tracing for H2 should be in this list
CHANGES.md
Outdated
|
|
||
| Full release notes: | ||
|
|
||
| * Enables third-party identifiers to emit router stats. |
There was a problem hiding this comment.
Consider using similar wording for this feature from a previous release:
* Pass stack params to announcer plugins, allowing them to report metrics correctly.
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
adleong
approved these changes
Jun 12, 2018
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
olix0r
approved these changes
Jun 13, 2018
Tim-Brooks
pushed a commit
to Tim-Brooks/linkerd
that referenced
this pull request
Dec 20, 2018
linkerd#1987) Signed-off-by: Kevin Lingerfelt <kl@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up release that includes diagnostic tracing for H2 requests.
Full release notes:
the end of h2 streams to downstream services.
Signed-off-by: Dennis Adjei-Baah dennis@buoyant.io