Pass router param inputs to identifiers #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
dadjeibaah
approved these changes
Jul 11, 2018
| @@ -113,7 +113,7 @@ class HttpConfigTest extends FunSuite with Awaits { | |||
| |- port: 5000 | |||
| """.stripMargin | |||
| val config = parse(yaml) | |||
| val identifier = config.routerParams[Http.param.HttpIdentifier] | |||
| val identifier = config.routerParams(Stack.Params.empty)[Http.param.HttpIdentifier] | |||
| .id(Path.read("/svc"), () => Dtab.empty) | |||
| val req = Request(Method.Get, "/one/two/three") | |||
| assert( | |||
There was a problem hiding this comment.
Should we add a test that validates that we are receiving a StatsReceiver in an identifier to show that it propagates through initialization?
olix0r
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack params are passed to identifier plugins to configure them. However, only params from the router config are passed to the identifier. In particular, this means that the stats receiver is not available to the identifier because it is not a router config param.
Pass stack params as input to the router params. This allows the stats receiver to be passed into the router params.
Fixes #1963
Signed-off-by: Alex Leong alex@buoyant.io