Test CNI ordering #248
Merged
Test CNI ordering #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpeb
force-pushed
the
alpeb/cni-plugin-test-node-scale
branch
from
cd75f0a
to
a4ca193
Compare
alpeb
force-pushed
the
alpeb/cni-plugin-test-node-scale
branch
2 times, most recently
from
9d9395a
to
92b6d0a
Compare
Followup to #242 This adds a new integration test that verifies that pods don't get scheduled until all the networking has been setup, making sure having linkerd-cni run run first doesn't trigger scheduling. Note that for now we just consider the linkerd-cni+calico combo. Worklow: 1. Install calico and linkerd-cni. 2. Label node and then add node selectors to calico and linkerd-cni to run only on the current node. 3. Create a new node. Calico nor linkerd-cni will be triggered in it. 4. Persist an nginx pod in that node. Verify it doesn't get scheduled. 5. Add label to linkerd-cni to have it trigger in the new node. 6. Verify the nginx pod still isn't scheduled. 7. Add label to calico to have it trigger in the new node. 8. Verify the nginx pod is finally scheduled. Note that currently the test fails at step 6, but will pass as soon #242 gets merged. In order to test succesfully, you can apply this patch: ```diff diff --git a/cni-plugin/integration/manifests/calico/linkerd-cni.yaml b/cni-plugin/integration/manifests/calico/linkerd-cni.yaml index 05f110b..419abdd 100644 --- a/cni-plugin/integration/manifests/calico/linkerd-cni.yaml +++ b/cni-plugin/integration/manifests/calico/linkerd-cni.yaml @@ -123,7 +123,7 @@ spec: # script copies the files into place and then sleeps so # that Kubernetes doesn't keep trying to restart it. - name: install-cni - image: test.l5d.io/linkerd/cni-plugin:test + image: ghcr.io/alpeb/cni-plugin:v1.2.8 #image: cr.l5d.io/linkerd/cni-plugin:edge-22.12.1 env: - name: DEST_CNI_NET_DIR ```
alpeb
force-pushed
the
alpeb/cni-plugin-test-node-scale
branch
from
92b6d0a
to
b446c6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #242
This adds a new integration test that verifies that pods don't get scheduled until all the networking has been setup, making sure having linkerd-cni run run first doesn't trigger scheduling.
Note that for now we just consider the linkerd-cni+calico combo.
Worklow:
Note that currently the test fails at step 6, but will pass as soon #242 gets merged.
Update: now that #242 has been merged, the tests are green 馃憤