Bump k3d to v5.5.1 #31
Conversation
actions/setup-tools/action.yml
Outdated
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends jo jq | ||
| # override k3s-image.json with current one | ||
| cp k3s-images.json $K3S_IMAGES_JSON |
There was a problem hiding this comment.
I don't think this change is desirable: this is failing for you because the published image is out of sync with the repo. The fix for this should be to get the image published.
This change as it stands won't generally work outside of this repo... Will it?
There was a problem hiding this comment.
Ah good point, I didn't think of this action outside the context of the current repo.
The fix for this should be to get the image published.
You mean to pull k3-images.json via the sync-k3s-images recipe?
There was a problem hiding this comment.
Oh I understand now, you're saying we should just publish this, without the snippet above, and regardless of the CI failure?
There was a problem hiding this comment.
Ok I've pushed a commit undoing this part.
|
Here, I've pushed a v41 with these changes. #32 |
Unblocks linkerd/linkerd2-proxy-init#248
Also updated k3s-images.json, and made sure the current version is used in setup-tools (otherwise
just-k3d createfails when trying to use a k3s version not declared in the older k3s-image.json file).