dst: Log a warning when the controller clients receive an error #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The controller client includes a recovery/backoff module that causes resolutions to be retried when an unexpected error is encountered. These events are only logged at debugging and trace log levels. This change updates the destination controller recovery module to log unexpected errors. This will benefit both profile and endpoint resolution.
|
Followup for linkerd/linkerd2#11555 |
hawkw
approved these changes
Nov 1, 2023
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would not properly reflect grpc-status in metrics by default. Furthermore, proxies now long warnings when they receive unexpected error responses from the control plane. --- * chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487) * gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491) * Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498) * gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493) * Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499) * inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496) Signed-off-by: Oliver Gould <ver@buoyant.io>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 2, 2023
This release includes several bugfixes. Notably, inbound proxies would not properly reflect grpc-status in metrics by default. Furthermore, proxies now long warnings when they receive unexpected error responses from the control plane. --- * chore: change `rust-toolchain` file to toml format (linkerd/linkerd2-proxy#2487) * gate: Detect disconnected inner services in readiness (linkerd/linkerd2-proxy#2491) * Bump ahash to v0.8.5 (linkerd/linkerd2-proxy#2498) * gate: Fix readiness deadlock (linkerd/linkerd2-proxy#2493) * Log a warning when the controller clients receive an error (linkerd/linkerd2-proxy#2499) * inbound: Fix gRPC response classification (linkerd/linkerd2-proxy#2496) Signed-off-by: Oliver Gould <ver@buoyant.io>
alpeb
pushed a commit
that referenced
this pull request
Nov 6, 2023
The controller client includes a recovery/backoff module that causes resolutions to be retried when an unexpected error is encountered. These events are only logged at debugging and trace log levels. This change updates the destination and policy controller recovery modules to log unexpected errors as warnings.
alpeb
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 6, 2023
## stable-2.14.3 This stable release fixes an issue in the Destination controller that was forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases the log level from debug to warning when the outbound proxy faces this type of events. * Fixed `GetProfiles` error when address is opaque and unmeshed ([#11556], fixes[#11555]) * Started logging at warning level when the controller clients receive an error ([#2499]) [#11556]: #11556 [#11555]: #11555 [#2499]: linkerd/linkerd2-proxy#2499
hawkw
pushed a commit
that referenced
this pull request
Nov 6, 2023
The controller client includes a recovery/backoff module that causes resolutions to be retried when an unexpected error is encountered. These events are only logged at debugging and trace log levels. This change updates the destination and policy controller recovery modules to log unexpected errors as warnings.
alpeb
added a commit
to linkerd/linkerd2
that referenced
this pull request
Nov 7, 2023
Changes for stable-2.14.3 This stable release fixes an issue in the Destination controller that was forbidding to route traffic to opaque ports on unmeshed pods. Also, it increases the log level from debug to warning when the outbound proxy faces this type of events. * Fixed `GetProfiles` error in the Destination controller when address is opaque and unmeshed ([#11556], fixes[#11555]) * Started logging at warning level in the proxy when the controller clients receive an error ([#2499]) [#11556]: #11556 [#11555]: #11555 [#2499]: linkerd/linkerd2-proxy#2499
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller client includes a recovery/backoff module that causes resolutions to be retried when an unexpected error is encountered. These events are only logged at debugging and trace log levels.
This change updates the destination controller recovery module to log unexpected errors. This will benefit both profile and endpoint resolution.