Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dst: Log a warning when the controller clients receive an error #2499

Merged
merged 4 commits into from Nov 1, 2023
Merged

dst: Log a warning when the controller clients receive an error #2499

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a51776
dst: Log a warning when the controller clients receive an error
olix0r Nov 1, 2023
8ccbaea
Add warnings in the policy controller client too
olix0r Nov 1, 2023
0bfc787
Inbound policy controller too
olix0r Nov 1, 2023
2eea895
Merge branch 'main' into ver/log-disco-error
olix0r Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion linkerd/app/src/dst.rs
View file
Open in desktop
Expand Up @@ -94,7 +94,11 @@ impl Recover<tonic::Status> for BackoffUnlessInvalidArgument {
return Err(status);
}

tracing::trace!(%status, "Recovering");
tracing::warn!(
grpc.status = %status.code(),
grpc.message = status.message(),
"Unexpected destination controller response; retrying with a backoff",
);
Ok(self.0.stream())
}
}