Skip to content

Commit

Permalink
Destination controller should initialize jobs metadata api (#11541)
Browse files Browse the repository at this point in the history
The destination controller uses the metadata API to retrieve Job metadata, but does not properly initialize the metadata API to sync jobs. This results in error messages in the log and a fallback to using direct API calls instead of the informer cache.

We properly initialize the jobs informer so that this works as expected.

Signed-off-by: Alex Leong <alex@buoyant.io>
  • Loading branch information
adleong committed Oct 27, 2023
1 parent 82848e8 commit 9f210a0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion controller/cmd/destination/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func Main(args []string) {
log.Fatalf("Failed to initialize K8s API: %s", err)
}

metadataAPI, err := k8s.InitializeMetadataAPI(*kubeConfigPath, "local", k8s.Node, k8s.RS)
metadataAPI, err := k8s.InitializeMetadataAPI(*kubeConfigPath, "local", k8s.Node, k8s.RS, k8s.Job)
if err != nil {
log.Fatalf("Failed to initialize Kubernetes metadata API: %s", err)
}
Expand Down

0 comments on commit 9f210a0

Please sign in to comment.