Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove shortnames from Tap API resources (#11816)
The Tap API resource shortnames were colliding with existing Kubernetes resources (e.g. `po`, `deploy`, etc), causing warnings from kubectl v1.29.0+. Remove the shortnames from the Tap APIService handlers. To validate: ```bash bin/k3d cluster create # install latest edge curl https://run.linkerd.io/install-edge | sh linkerd install --crds | kubectl apply -f - linkerd install | kubectl apply -f - linkerd check linkerd viz install | kubectl apply -f - linkerd check # observe shortnames kubectl api-resources --api-group=tap.linkerd.io # with kubectl v1.29.0+, observe "Warning: short name..." kubectl get po # replace tap image TAP_IMAGE=$(bin/docker-build-tap) bin/k3d image load $TAP_IMAGE kubectl -n linkerd-viz set image deploy/tap tap=$TAP_IMAGE # verify shortnames are no longer present kubectl api-resources --api-group=tap.linkerd.io # with kubectl v1.29.0+, observe no warning kubectl get po ``` Fixes #11784 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
- Loading branch information