Tap APIService causes shortname conflict warnings with kubectl 1.29

[siggy]

What is the issue?

When running with Kubectl 1.29 with a cluster with linkerd-viz, I get these warnings when running kubectl commands:

Warning: short name "deploy" could also match lower priority resource deployments.tap.linkerd.io

The TAP APIService uses shortnames that collide with other Kubernetes resources (e.g. deploy, po, etc):

linkerd2/viz/tap/api/handlers.go

Lines 56 to 72 in 913e118

	resources = []struct {
	name string
	shortname string
	namespaced bool
	}{
	{"namespaces", "ns", false},
	{"pods", "po", true},
	{"replicationcontrollers", "rc", true},
	{"services", "svc", true},
	{"daemonsets", "ds", true},
	{"deployments", "deploy", true},
	{"replicasets", "rs", true},
	{"statefulsets", "sts", true},
	{"jobs", "", true},
	{"cronjobs", "cj", true},
	}
	)

How can it be reproduced?

With kubectl 1.29+ on a cluster with linkerd-viz installed, run kubectl get deploy.

Logs, error output, etc

$ kubectl version
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.28.3

$ kubectl get deploy
Warning: short name "deploy" could also match lower priority resource deployments.tap.linkerd.io
NAME      READY   UP-TO-DATE   AVAILABLE   AGE
hello     3/3     3            3           650d
traffic   1/1     1            1           640d

output of linkerd check -o short

$ linkerd check -o short
linkerd-identity
----------------
‼ issuer cert is valid for at least 60 days
    issuer certificate will expire on 2024-01-08T00:00:24Z
    see https://linkerd.io/2/checks/#l5d-identity-issuer-cert-not-expiring-soon for hints

Status check results are √

Environment

• Kubernetes Version: v1.28.3
• Cluster Environment: AKS
• Host OS: Ubuntu
• Linkerd version: edge-23.12.2

Possible solution

Remove or modify the shortnames in the Tap APIService:

linkerd2/viz/tap/api/handlers.go

Lines 56 to 72 in 913e118

	resources = []struct {
	name string
	shortname string
	namespaced bool
	}{
	{"namespaces", "ns", false},
	{"pods", "po", true},
	{"replicationcontrollers", "rc", true},
	{"services", "svc", true},
	{"daemonsets", "ds", true},
	{"deployments", "deploy", true},
	{"replicasets", "rs", true},
	{"statefulsets", "sts", true},
	{"jobs", "", true},
	{"cronjobs", "cj", true},
	}
	)

Additional context

Relates to kubernetes/kubernetes#108573

Would you like to work on fixing this bug?

yes