Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inject flag for disabling tap #2778

Closed
adleong opened this issue May 1, 2019 · 0 comments · Fixed by #2807
Closed

Add inject flag for disabling tap #2778

adleong opened this issue May 1, 2019 · 0 comments · Fixed by #2807
Assignees
Labels
area/cli priority/P1 Planned for Release

Comments

@adleong
Copy link
Member

adleong commented May 1, 2019

Add a --disable-tap flag to inject which prevents the pod from being tapped by instructing the proxy to not expose a tap server.

  • Introduce a proxy environment variable to disable the tap server
  • Add an inject flag to set the proxy env var
  • Also set an annotation on the pod to indicate that tap has been disabled on that pod so that the control plane knows to exclude that pod from any taps
@grampelberg grampelberg added area/cli priority/P1 Planned for Release labels May 6, 2019
@alpeb alpeb self-assigned this May 9, 2019
alpeb added a commit that referenced this issue May 9, 2019
Fixes #2778

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
alpeb added a commit that referenced this issue May 10, 2019
Support for resources opting out of tap

Implements the `linkerd inject --disable-tap` flag (although hidden pending #2811) and the config override annotation `config.linkerd.io/disable-tap`.
Fixes #2778

Signed-off-by: Alejandro Pedraza <alejandro@buoyant.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli priority/P1 Planned for Release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants