Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the generation of the Helm chart's README files #4156

Closed
alpeb opened this issue Mar 9, 2020 · 6 comments · Fixed by #5316
Closed

Automate the generation of the Helm chart's README files #4156

alpeb opened this issue Mar 9, 2020 · 6 comments · Fixed by #5316

Comments

@alpeb
Copy link
Member

alpeb commented Mar 9, 2020

Leverage a tool like helm-docs to generate the Helm chart's README files automatically based on annotations in the values.yaml files, prior to publishing the charts in CI.

@stale
Copy link

stale bot commented Jun 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@alpeb
Copy link
Member Author

alpeb commented Jun 8, 2020

This would save us some time for sure... Added a couple of labels

@GMarkfjard
Copy link
Contributor

Would love to pick this up as a part of my open source contribution course!

@alpeb Could you assign me to this?

@alpeb
Copy link
Member Author

alpeb commented Sep 8, 2020

Thanks @GMarkfjard , that'd be amazing!

@GMarkfjard
Copy link
Contributor

GMarkfjard commented Sep 21, 2020

So when creating the CI steps for the generation, where would you want to have them? I figured release.yml should obviously contain a step for generating the readme:s so that the repo gets the generated readme:s. Would it be beneficial to also put it in, say, static-checks.yml for reading any updates in a PR?

@alpeb

@alpeb
Copy link
Member Author

alpeb commented Sep 22, 2020

@GMarkfjard The problem with putting the README sgeneration in CI is that it'd require CI pushing changes into the repo, which can complicate things a bit. How about having a new script under bin/ for generating this, to be run manually? And then have in static-checks.yml something that checks that the READMEs are up-to-date. Similar to the "Proto diff" job we have in there that checks the protobuf generated code is current.

GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 4, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 5, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 11, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 17, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 17, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 18, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 18, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Nov 18, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Dec 2, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
GMarkfjard added a commit to GMarkfjard/linkerd2 that referenced this issue Dec 2, 2020
The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Validation done by testing locally.

Fixes linkerd#4156

Signed-off-by: Gabriel Markfjärd <gabma047@student.liu.se>
alpeb added a commit that referenced this issue Dec 2, 2020
* Add automatic readme generation for charts

The current readmes for each chart is generated
manually and doesn't contain all the information available.

Utilize helm-docs to automatically fill out readme.mds
for the helm charts by pulling metadata from values.yml.

Fixes #4156

Co-authored-by: GMarkfjard <gabma047@student.liu.se>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants