Require Rust 1.23 in proxy Dockerfile-deps #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this into your other PR so that both changes happen in the same merge. You can do this by changing the base branch of this PR from "master" to the branch for your other PR. Then when you merge this PR, it will get merged into the other PR, and then you can merge the combined thing at once into master. More generally, it's good to break things into multiple PRs but we should never have a merge to master that breaks the build even temporarily. |
briansmith
approved these changes
Jan 4, 2018
|
@briansmith, I was originally going to make this change in PR #104, but @olix0r requested that the Dockerfile change be made separately. In the future, I think we should codify this in documentation somewhere. |
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/update-rust
branch
from
e609591
to
4f8d3a6
Compare
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
The control client implements a backoff service that dampens reconnect attempts to the control plane by waiting a fixed period of time after a failure. Furthermore, the control client logs errors each time a reconnect attempt fails. This change moves backoff logic from control::destination::background::client to proxy::reconnect. Because the reconnect module handles connection errors uniformly, muting repeated errors, it also has enough context to know when a backoff should be applied -- when the underlying NewService cannot produce a Service. If polling the inner service fails once the Service has been established, we do not want to apply a backoff, since this may just be the result of a connection being terminated, a process being restarted, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #104, Conduit will not build against pre-1.23 Rust versions. This PR updates the Dockerfile to require this version.
Signed-off-by: Eliza Weisman eliza@buoyant.io