Fix linkerd inject url handling #3039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2988 introduced support for `linkerd inject` with a URL parameter. Some edge cases such as `/foo/bar/baz.yml` will return without error from `url.ParseRequestURI`, even though we know this is a valid local filename. Modify inject's URL check to specifically look for a valid `http[s]://` prefix. If that check succeeds, we will still rely on `http.Get` for URL validation, as it calls `url.Parse` under the hood. Fixes #3037 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
|
Integration test results for 736e1a7: success 🎉 |
Pothulapati
approved these changes
Jul 5, 2019
|
@Pothulapati I really did try to add a test file, but the |
|
closing in favor of #3038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2988 introduced support for
linkerd injectwith a URL parameter.Some edge cases such as
/foo/bar/baz.ymlwill return without errorfrom
url.ParseRequestURI, even though we know this is a valid localfilename.
Modify inject's URL check to specifically look for a valid
http[s]://prefix. If that check succeeds, we will still rely on
http.Getfor URLvalidation, as it calls
url.Parseunder the hood.Fixes #3037
Signed-off-by: Andrew Seigner siggy@buoyant.io